This repository was archived by the owner on Aug 15, 2026. It is now read-only.
Fix __version__ drift by deriving from package metadata - #3
Draft
bedardandy wants to merge 1 commit into
Draft
bedardandy wants to merge 1 commit into
bedardandy wants to merge 1 commit into
Conversation
__version__ was hardcoded to 0.5.0 while pyproject declared 0.6.0 (which downstream siblings pin), so any check keyed on __version__ read a stale value. Derive it from importlib.metadata with a 0.6.0 fallback, and add a test asserting it matches the installed distribution version. Co-authored-by: Andy Bedard <bedardandy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src/maine_forms_engine/__init__.pyhardcoded__version__ = "0.5.0"whilepyproject.tomldeclaredversion = "0.6.0"(which the sibling repos pin as@v0.6.0). Any consumer keyed on__version__read a stale value;importlib.metadata.version("maine-forms-engine")andmaine_forms_engine.__version__disagreed.Fix
Derive
__version__from installed distribution metadata viaimportlib.metadata.version("maine-forms-engine"), with aPackageNotFoundErrorfallback of"0.6.0"so it can't silently drift frompyprojectagain.Tests
tests/test_version.pyasserting__version__ == importlib.metadata.version("maine-forms-engine").150 passed, 2 skipped, 1 xfailed.Part of a cross-repo review-fix batch; not legal advice.