feat: add queue action hooks#1
Open
mikehostetler wants to merge 1 commit into
Open
Conversation
Supports intent-ledger-28h.3
jallum
approved these changes
May 14, 2026
| Store.requeue(state.repo, state.root, lease, base_delay: delay_ms, max_delay: delay_ms) | ||
| end | ||
|
|
||
| with :ok <- normalize_queue_result(queue_result), |
Collaborator
There was a problem hiding this comment.
blocking if this PR merges independently: when run_action_hook/5 returns {:error, reason}, this with returns an error tuple from inside repo.transact/1; Bedrock commits returned values unless repo.rollback/1 is called. PR #2 adds the rollback path, so I would either merge these as a stack or pull that rollback handling into this PR before merging #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
on_actionhook toBedrock.JobQueueconfigurationTests
mix format --check-formatted && mix test