Skip to content

[16.0][FIX] shift : hide parent name in kanban view #596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-grap-bot merged 1 commit into from
Jul 15, 2026
Merged

[16.0][FIX] shift : hide parent name in kanban view #596

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion shift/models/planning.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,9 @@ def _compute_remaining(self):
@api.depends("worker_ids")
def _compute_worker_name(self):
for rec in self:
rec.worker_name = ",".join(rec.worker_ids.mapped("display_name"))
# name rather than display_name, so the parent doesn't appear
# on worker list in kanban
rec.worker_name = ",".join(rec.worker_ids.mapped("name"))
Comment on lines +275 to +277

@huguesdk huguesdk Jul 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it’s good to have a comment, but as this explains the change and not the why this line is here, it’s better to put it in the commit message (next time). feel free to give as much explanation as relevant in the commit message. it’s even better there than in the pull request, as it’s easier to find back when inspecting the code.


@api.constrains("worker_nb", "worker_ids")
def _nb_worker_max(self):
Expand Down
Loading