Package and release the macOS plugin as an OpenCPN import tarball - #12
Merged
Conversation
Package.cmake gains the darwin-wx32 layout: the dylib rides at OpenCPN.app/Contents/PlugIns/, which is the path component the installer (apple_entry_set_install_path) keys on, and the tarball name carries the arch since darwin-wx32 does not. On macOS OpenCPN never compares the target version; it accepts a tarball whose target-arch contains the host's arch string, so the two per-arch tarballs land on the right hosts (a Rosetta-translated OpenCPN reports x86_64 and gets the intel build). CI's macos job now packages and uploads the tarball instead of the bare dylib, and release.yml gains the matching per-arch macos legs feeding the GitHub release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package.cmake gains the darwin-wx32 layout: the dylib rides at OpenCPN.app/Contents/PlugIns/, which is the path component the installer (apple_entry_set_install_path) keys on, and the tarball name carries the arch since darwin-wx32 does not. On macOS OpenCPN never compares the target version; it accepts a tarball whose target-arch contains the host's arch string, so the two per-arch tarballs land on the right hosts (a Rosetta-translated OpenCPN reports x86_64 and gets the intel build).
CI's macos job now packages and uploads the tarball instead of the bare dylib, and release.yml gains the matching per-arch macos legs feeding the GitHub release.