Skip to content

🔒 Prevent CWD binary-hijacking in shell-spawning - #15

Merged
beingniloy merged 2 commits into
mainfrom
jules-14361585504435194355-98eca206
Jul 20, 2026
Merged

🔒 Prevent CWD binary-hijacking in shell-spawning#15
beingniloy merged 2 commits into
mainfrom
jules-14361585504435194355-98eca206

Conversation

@beingniloy

Copy link
Copy Markdown
Owner

🎯 What

The shell selection (restart-shell) IPC channel was hardened to prevent potential CWD binary-hijacking and path-traversal bypasses.

⚠️ Risk

When spawning a shell process with a relative/simple binary name (e.g. powershell.exe or cmd.exe) in a multi-tenant or untrusted workspace, Windows/POSIX OSes may resolve the binary relative to the current working directory (workspaceRoot). A malicious user could place a rogue executable named powershell.exe in the project root to achieve arbitrary code execution.

🛡️ Solution

All allowed shells are now mapped to secure, absolute system paths on the secure Electron main-process side (using environment properties like %SystemRoot% on Windows, or standard locations like /bin / /usr/bin on POSIX) before spawning the process.


PR created automatically by Jules for task 14361585504435194355 started by @beingniloy

Harden shell spawning in Electron main process by mapping all
whitelisted shell paths to secure, absolute system paths. This
completely prevents potential CWD binary-hijacking or path-traversal
bypass attempts.

Co-authored-by: beingniloy <235952944+beingniloy@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Harden shell spawning in Electron main process by mapping all
whitelisted shell paths to secure, absolute system paths. This
completely prevents potential CWD binary-hijacking or path-traversal
bypass attempts.

Co-authored-by: beingniloy <235952944+beingniloy@users.noreply.github.com>
@beingniloy
beingniloy merged commit a847122 into main Jul 20, 2026
3 of 4 checks passed
@beingniloy
beingniloy deleted the jules-14361585504435194355-98eca206 branch July 20, 2026 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant