🔒 Prevent CWD binary-hijacking in shell-spawning - #15
Conversation
Harden shell spawning in Electron main process by mapping all whitelisted shell paths to secure, absolute system paths. This completely prevents potential CWD binary-hijacking or path-traversal bypass attempts. Co-authored-by: beingniloy <235952944+beingniloy@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Harden shell spawning in Electron main process by mapping all whitelisted shell paths to secure, absolute system paths. This completely prevents potential CWD binary-hijacking or path-traversal bypass attempts. Co-authored-by: beingniloy <235952944+beingniloy@users.noreply.github.com>
🎯 What
The shell selection (
restart-shell) IPC channel was hardened to prevent potential CWD binary-hijacking and path-traversal bypasses.When spawning a shell process with a relative/simple binary name (e.g.
powershell.exeorcmd.exe) in a multi-tenant or untrusted workspace, Windows/POSIX OSes may resolve the binary relative to the current working directory (workspaceRoot). A malicious user could place a rogue executable namedpowershell.exein the project root to achieve arbitrary code execution.🛡️ Solution
All allowed shells are now mapped to secure, absolute system paths on the secure Electron main-process side (using environment properties like
%SystemRoot%on Windows, or standard locations like/bin//usr/binon POSIX) before spawning the process.PR created automatically by Jules for task 14361585504435194355 started by @beingniloy