feat(frontend): pagination, geometries#8
Open
zameji wants to merge 15 commits into
Open
Conversation
zameji
marked this pull request as ready for review
June 3, 2024 20:23
Closed
zameji
changed the title
loganwilliams
self-requested a review
July 5, 2024 11:10
Contributor
|
@zameji I've (finally) started to look into this, but it seems like this PR still contains lots of backend commits. Can you take a look and cherry pick the front-end ones so that I can move this forward? |
Author
|
@loganwilliams I'll look into it. I hope I separated the commits by frontend / backend, otherwise this will be a real headache. |
zameji
force-pushed
the
feat(frontend)!--pagination,-geometries
branch
from
July 9, 2024 20:22
f2530b0 to
fcd6aaf
Compare
Author
|
@loganwilliams Alright, I went through the commit history and cleaned it up - both here and in the backend PR #9 . Luckily, only a couple of commits had a mix of backend/frontend files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAIK this is backward-compatible with current backend. You wouldn't be able to use pagination and display the geometries (actually the search result list would not show any marker at all), but it should still work.