"Fix" tests - #46
Open
NoraCodes wants to merge 11 commits into
Open
"Fix" tests #46NoraCodes wants to merge 11 commits into
NoraCodes wants to merge 11 commits into
Conversation
That is - all tests!
… list of every possible game state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove all the tests which test only shims - that is, all the tests!
The tests we have are testing only the shims we wrote last semester. I did this because it's very annoying to work with a codebase full of failing tests, so future PRs can be based on this branch that has none. This is not an indictment of your tests, these tests are fine but just don't test anything.
Please don't merge this pr - but, instead, actually fix the tests, by making them test things in the
riverCrossingpackage.Remember, you can run the tests with
python3 -m unittest tests.