Closed
Conversation
neatudarius
approved these changes
Jun 15, 2025
Member
neatudarius
left a comment
neatudarius
left a comment
There was a problem hiding this comment.
LGTM
I think we'd also benefit from having a pre-commit GitHub Action, just like the one beman/inplace-vector has. I can make a separate PR for that if there's interest.
Yes, please do that.
Member
Contributor
Author
|
I just checked and you're right, this PR is no longer required. It's safe to close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3.
I simply ran
pre-commiton the repo.I think we'd also benefit from having a
pre-commitGitHub Action, just like the onebeman/inplace-vectorhas. I can make a separate PR for that if there's interest.