Feature/controller-enhancements

[ben-fornefeld]

Note

Implemented by @msamoeed in #25

Enhanced MeshGradientController with Integrated Sequence Repetition

Changes

• Modified animateSequence method to include repeatCount and pauseBetweenRepeats parameters
• Integrated sequence repetition functionality directly into animateSequence
• Removed separate repeatSequenceAnimation method
• Refactored animateSequence for better code organization and reusability

Motivation

This update streamlines the API for animating mesh gradient sequences by incorporating repetition functionality directly into the animateSequence method. It simplifies usage and reduces code duplication while maintaining flexibility for complex animations.

Impact

• Improved API consistency and ease of use
• Enhanced control over sequence animations with built-in repetition
• Reduced method count in the controller class

Usage Example

controller.animateSequence(
  duration: Duration(seconds: 2),
  sequences: [/* ... */],
  repeatCount: 3,
  pauseBetweenRepeats: Duration(milliseconds: 500),
);

This PR enhances the MeshGradientController's capabilities while simplifying its interface, making it more intuitive for developers to create complex, repeating gradient animations.

[ben-fornefeld]

bugbot run

[cursor]

Bug: Animation Controller Leak in Animation Methods

The animatePoint and animateSequence methods can leak AnimationController instances. If an exception occurs after a controller is added to _activeAnimationControllers but before its completion listener removes it, the controller remains in the list. This prevents disposal, leading to a memory leak and an inaccurate isAnimating state.

Additional Locations (1)

• lib/src/widgets/mesh_gradient/mesh_gradient_controller.dart#L111-L152

 

[cursor]

Bug: Animation Controller Disposal Causes Concurrent Modification

In stopAllAnimations, calling controller.stop() triggers the animation's status listener. This listener disposes the controller and removes it from _activeAnimationControllers, causing a double disposal and a concurrent modification error while iterating the list.