[MST-19] Update to use shared Login component from component-library#4
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
[MST-19] Update to use shared Login component from component-library#4devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
- Replace local Login component with shared component from component-library - Configure props for viagogo branding (#70b42c green theme) and Facebook login - Remove conflicting CSS rules that override component-library theming Addresses MST-19: Componentize login forms in component library Co-Authored-By: ben.lehrburger@windsurf.com <ben.lehrburger@windsurf.com>
Co-Authored-By: ben.lehrburger@windsurf.com <ben.lehrburger@windsurf.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MST-19] Add reusable Login component with configurable theming
Summary
Created a reusable Login component that consolidates login forms from
browse-app,vg-browse, andmy-account-appinto the component-library. The component supports configurable branding (logos, theme colors, brand names) and social sign-in options while maintaining existing design patterns.Key Features:
logo,brandName,themeColor,socialLogins,showEmailCode, etc.--theme-color,--brand-color)Critical Fix: Ensured
themeColorprop applies to ALL CTAs/buttons (not just checkboxes) by updating CSS inheritance rules and button hover states.Review & Testing Checklist for Human
themeColorprop applies to ALL buttons/CTAs including sign-in button, email code button, and checkbox accent colorRecommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% flowchart TD CL["component-library<br/>src/components/Login/"]:::major-edit CLI["Login.js<br/>(new component)"]:::major-edit CLCSS["Login.css<br/>(theming system)"]:::major-edit CLI["src/index.js<br/>(exports)"]:::minor-edit BA["browse-app<br/>src/Login.js"]:::major-edit VG["vg-browse<br/>src/Login.js"]:::major-edit MA["my-account-app<br/>src/components/Login.tsx"]:::major-edit MACSS["my-account-app<br/>src/main.tsx<br/>(CSS import)"]:::minor-edit SITE["my-account-app<br/>src/styles/site.css<br/>(removed conflicts)"]:::minor-edit CL --> CLI CL --> CLCSS CL --> CLI CLI --> BA CLI --> VG CLI --> MA CLCSS --> BA CLCSS --> VG CLCSS --> MA MACSS --> MA SITE --> MA subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
main.tsx, unlike Create React App which handles this automatically.login-containerCSS rules in my-account-app'ssite.cssthat were overriding component-library styles--theme-colorcustom property applies to all interactive elements, not just checkboxesSession Details: