MST-18: Integrate reusable Login component and fix viagogo theme colors#5
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
MST-18: Integrate reusable Login component and fix viagogo theme colors#5devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
- Remove hardcoded purple .email-code-btn styles that override component library - Remove duplicated .login-container background styling - Allows component library CSS custom properties to work correctly - Fixes viagogo 'Sign in with Email Code' button to show green outline Related to MST-18 Co-Authored-By: ben.lehrburger@windsurf.com <ben.lehrburger@windsurf.com>
- Change theme color from #00b04f to #70b42c as requested - Ensures all viagogo login elements use the correct brand green color Related to MST-18 Co-Authored-By: ben.lehrburger@windsurf.com <ben.lehrburger@windsurf.com>
- Replace local login form with @ben-windsurf/component-library Login component - Update viagogo theme color to correct green (#70b42c) - Remove conflicting CSS rules that caused purple outline on email code button - Update package.json to include component library dependency - Maintain viagogo branding with green theme and social login options Related to MST-19 Co-Authored-By: ben.lehrburger@windsurf.com <ben.lehrburger@windsurf.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MST-18: Integrate reusable Login component from component library
Summary
This PR replaces local login form implementations across three applications (browse-app, vg-browse, my-account-app) with a centralized reusable
Logincomponent from@ben-windsurf/component-library. The component is parameterized to support different branding, theme colors, and social login configurations while maintaining existing functionality.Major Changes:
Technical Approach:
Review & Testing Checklist for Human
🔴 HIGH PRIORITY - Must verify manually:
Recommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TB CL["@ben-windsurf/component-library<br/>Login component"]:::major-edit BA["browse-app<br/>src/Login.js"]:::major-edit BAP["browse-app<br/>package.json"]:::minor-edit BAC["browse-app<br/>src/App.css"]:::minor-edit VG["vg-browse<br/>src/Login.js"]:::major-edit VGP["vg-browse<br/>package.json"]:::minor-edit VGC["vg-browse<br/>src/App.css"]:::minor-edit MA["my-account-app<br/>Login.tsx"]:::major-edit MAP["my-account-app<br/>package.json"]:::minor-edit MAC["my-account-app<br/>App.tsx"]:::minor-edit MACS["my-account-app<br/>site.css"]:::minor-edit CL -->|"imports component"| BA CL -->|"imports component"| VG CL -->|"imports component"| MA BAP -->|"dependency"| CL VGP -->|"dependency"| CL MAP -->|"dependency"| CL subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
Link to Devin run: https://app.devin.ai/sessions/8ff48278395143fd9afd3ed1402e0e17
Requested by: @ben-windsurf
Related PRs: