Draft
Live game viewer: update outcome and player online status during polling#589
Conversation
…online status - Extend LatestGamesUpdateResponse.Entry with outcome, isRedOnline, isBlackOnline - Fetch OUTCOME, INVITER, INVITEE, INVITER_COLOR for PvP games in fetchCurrentStatusAndFen - Fetch OUTCOME, USER_ID, USER_COLOR for PvB games in fetchCurrentStatusAndFen - Compute online status in fetchLatestGamesUpdate service method - Update LobbyClient.fetchLatestGamesUpdate JS to pass new fields - Update GameThumb.refresh() to update outcome (blue star) and player online indicators Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/e74c01a0-a636-4a7a-bbb9-b5ca38fdf6cd Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
…aService Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/e74c01a0-a636-4a7a-bbb9-b5ca38fdf6cd Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update live game viewer to show outcome and player status
Live game viewer: update outcome and player online status during polling
May 13, 2026
Owner
|
@copilot resolve the merge conflicts in this pull request |
Resolve conflict in GameDataService: switch fetchLatestGamesUpdate from userDaoService.fetchLastOnline() to userService.areOnline() to align with the approach used in the rest of the service after master was updated. Also removes the now-unused ONLINE_STATUS_THRESHOLD_SECONDS constant. Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/0727fae2-2a15-47f7-9e69-77289df8fb37 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Contributor
Author
Merged master (commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LatestGamesUpdateResponse.EntryKotlin DTO withoutcome,isRedOnline,isBlackOnlinefieldsfetchCurrentStatusAndFeninPlayerVsPlayerGameDaoServiceto also fetchGAME.OUTCOME,GAME.INVITER,GAME.INVITEE,GAME.INVITER_COLORfetchCurrentStatusAndFeninPlayerVsBotGameDaoServiceto also fetchBOT_GAME.OUTCOME,BOT_GAME.USER_ID,BOT_GAME.USER_COLORfetchLatestGamesUpdateinGameDataServiceto compute and include outcome and online statusLobbyClient.fetchLatestGamesUpdate(JS) to includeoutcome,isRedOnline,isBlackOnlinein update objectsGameThumb.refresh()(JS) to update the outcome (blue star) and online status indicatorsGameDataService(switch touserService.areOnline()pattern consistent with master)