Expose and surface pre-analyzed status in My Games, My Bot Games, and Admin Feeds#593
Conversation
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/012b00f7-d989-41be-ac8d-871cdca9747b Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/012b00f7-d989-41be-ac8d-871cdca9747b Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/012b00f7-d989-41be-ac8d-871cdca9747b Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
|
|
||
| private val logger = KotlinLogging.logger("Ops") | ||
|
|
||
| fun AnalysisStatus.isPreAnalyzed(): Boolean { |
There was a problem hiding this comment.
@copilot Drop this function and only AnalysisStatus.COMPLETED should be considered pre-analyzed.
There was a problem hiding this comment.
Done in commit 7d5f32d: I removed the shared AnalysisStatus.isPreAnalyzed() function and updated mappings so only AnalysisStatus.COMPLETED is treated as pre-analyzed. I also extended the focused test to assert PARTIALLY_COMPLETED is not pre-analyzed. Screenshot (icon update preview): /tmp/pre-analyzed-icon-preview.png.
| * @returns {HTMLDivElement} | ||
| */ | ||
| function buildPreAnalyzedIcon(gameId) { | ||
| const iconImg = buildImg('/images/icons/database.png', 'icon'); |
There was a problem hiding this comment.
@copilot would you be able to find another icon on https://www.flaticon.com/?
There was a problem hiding this comment.
Updated in commit 7d5f32d: I changed the pre-analyzed indicator to a different icon (/images/icons/stats.png) via my-game-item-utils.js so both My Games and My Bot Games use it consistently. Screenshot: /tmp/pre-analyzed-icon-preview.png.
There was a problem hiding this comment.
@copilot were you able to find and download a new icon? if not, I just whitelisted url of flaticon.com
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/3b7f8d74-735f-47ef-ba65-87e07f32ccb7 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot build is failing 🤔 |
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/22a923c9-936d-4ed9-9ae8-6744819cfe48 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/22a923c9-936d-4ed9-9ae8-6744819cfe48 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Fixed in Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot resolve the merge conflicts in this pull request |
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/a015f768-92d0-4614-90d3-70e1952af177 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Resolved in |
|
@copilot resolve the merge conflicts in this pull request |
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/e6a414b4-0176-46c5-a136-8332b7dbb689 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/e6a414b4-0176-46c5-a136-8332b7dbb689 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Resolved in |
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Resolved in |
|
|
||
| // pre-analysis indicator pane | ||
| if (entry.isPreAnalyzed) { | ||
| preAnalyzedIndicatorPane.append(buildPreAnalyzedIcon(entry.gameId)); |
There was a problem hiding this comment.
@copilot I would put this pane more on the left side of things, after the middle pane but before the chat pane
Uh oh!
There was an error while loading. Please reload this page.