Add contributors and last-edit metadata to DB player profile pages#595
Conversation
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/0a890f00-58d8-43ce-8a8a-87a83674942e Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/0a890f00-58d8-43ce-8a8a-87a83674942e Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
|
@copilot resolve the merge conflicts in this pull request |
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/c10fe46e-769e-49b1-b9cd-388de19bfe2c Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Done — I merged the latest |
|
@copilot resolve the merge conflicts in this pull request |
Agent-Logs-Url: https://github.com/benckx/elephantchess/sessions/41fc4b02-f403-4774-a667-f2e2aecc4069 Co-authored-by: benckx <8626080+benckx@users.noreply.github.com>
Resolved and pushed. I merged the latest |
|
@copilot resolve the merge conflicts in this pull request |
There was a problem hiding this comment.
@copilot why is this here? isn't it something used for user profile?
There was a problem hiding this comment.
You’re right — this DTO was unrelated to this PR’s scope. I removed the unintended user-profile stats DTO additions in commit 5af64fb.
There was a problem hiding this comment.
@copilot why is this here? isn't it something used for user profile?
There was a problem hiding this comment.
Correct — it was unrelated to this PR. I removed that DTO (and the paired PlayerVsPlayerStatsDto) in commit 5af64fb.
| } | ||
| } | ||
|
|
||
| // Opening explorer is only wired up (markup + scripts + stylesheet) for players that |
There was a problem hiding this comment.
Agreed — removing that was a mistake during conflict resolution. I restored the removed player-page/openings wiring in commit 5af64fb.
I synced this branch with the latest |
| } else { | ||
| buildString { | ||
| if (contributorsForDisplay.isNotEmpty()) { | ||
| append("""<span><b>Contributors:</b> $contributorsForDisplay</span>""") |
There was a problem hiding this comment.
@copilot can we use KtorHtmlBuilderTagResolver instead?
There was a problem hiding this comment.
Done — switched profile_meta_info to KtorHtmlBuilderTagResolver in commit f562d0b.
| <div class="main-container-text"> | ||
| <h1>{{page_title}}</h1> | ||
| <hr/> | ||
| <div id="profile-meta-info">{{profile_meta_info}}</div> |
There was a problem hiding this comment.
Done in commit 185239b — I moved the profile metadata block below the description.
| .distinct() | ||
| .sorted() | ||
| val contributorsForMeta = contributors.joinToString(", ").escapeHTML() | ||
| val contributorsForDisplay = contributors.joinToString(", ") { it.escapeHTML() } |
There was a problem hiding this comment.
@copilot also it needs to have the link to the profile, check ui.js "buildUsernameSpan" something
There was a problem hiding this comment.
Done in commit 185239b (with follow-up 058df58) — contributor names now link to user profiles (/@/{username}), matching the buildUsernameSpan behavior.
I checked and there are no remaining merge conflicts on this branch; it is already up to date with |
Uh oh!
There was an error while loading. Please reload this page.