Skip to content

Add contributors and last-edit metadata to DB player profile pages#595

Draft
benckx with Copilot wants to merge 10 commits into
masterfrom
copilot/add-authors-contributors-last-edit-date
Draft

Add contributors and last-edit metadata to DB player profile pages#595
benckx with Copilot wants to merge 10 commits into
masterfrom
copilot/add-authors-contributors-last-edit-date

Conversation

Copilot AI commented May 13, 2026

Copy link
Copy Markdown
Contributor
  • Fetch latest base branch and reproduce current merge-conflict state
  • Resolve any merge conflicts in this PR branch with minimal changes
  • Run targeted renderer test coverage for the conflicted area
  • Run final automated validation checks
  • Reply on the new PR comment with the resolving commit hash

Copilot AI changed the title [WIP] Add authors, contributors, and last edit date on DB player profile Add contributors and last-edit metadata to DB player profile pages May 13, 2026
Copilot AI requested a review from benckx May 13, 2026 09:07
Copilot finished work on behalf of benckx May 13, 2026 09:07
@benckx

benckx commented May 25, 2026

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Copilot AI commented May 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Done — I merged the latest master into this branch, resolved the conflict in DatabasePageRenderer, and pushed the result in commit 4c2beb7.

Copilot finished work on behalf of benckx May 25, 2026 15:52
@benckx

benckx commented May 26, 2026

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Copilot AI commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Resolved and pushed. I merged the latest master into this branch, fixed the conflicts, and pushed commit caed6a8.

Copilot finished work on behalf of benckx May 26, 2026 06:52
@benckx

benckx commented Jun 23, 2026

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot why is this here? isn't it something used for user profile?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re right — this DTO was unrelated to this PR’s scope. I removed the unintended user-profile stats DTO additions in commit 5af64fb.

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot why is this here? isn't it something used for user profile?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct — it was unrelated to this PR. I removed that DTO (and the paired PlayerVsPlayerStatsDto) in commit 5af64fb.

}
}

// Opening explorer is only wired up (markup + scripts + stylesheet) for players that

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot why would you remove this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed — removing that was a mistake during conflict resolution. I restored the removed player-page/openings wiring in commit 5af64fb.

Copilot AI commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

I synced this branch with the latest master and verified it is already up to date (no remaining merge conflict to resolve). I also pushed commit 5af64fb to clean up unintended files from the conflict-resolution history.

} else {
buildString {
if (contributorsForDisplay.isNotEmpty()) {
append("""<span><b>Contributors:</b> $contributorsForDisplay</span>""")

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot can we use KtorHtmlBuilderTagResolver instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done — switched profile_meta_info to KtorHtmlBuilderTagResolver in commit f562d0b.

<div class="main-container-text">
<h1>{{page_title}}</h1>
<hr/>
<div id="profile-meta-info">{{profile_meta_info}}</div>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot I'd put it below the description

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit 185239b — I moved the profile metadata block below the description.

.distinct()
.sorted()
val contributorsForMeta = contributors.joinToString(", ").escapeHTML()
val contributorsForDisplay = contributors.joinToString(", ") { it.escapeHTML() }

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot also it needs to have the link to the profile, check ui.js "buildUsernameSpan" something

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit 185239b (with follow-up 058df58) — contributor names now link to user profiles (/@/{username}), matching the buildUsernameSpan behavior.

Copilot AI commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

I checked and there are no remaining merge conflicts on this branch; it is already up to date with master (existing merge commit 595e81a).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add authors/contributors and last edit date on db player profile

2 participants