Skip to content

Make position editor modal height adaptive across displays#620

Draft
benckx with Copilot wants to merge 3 commits into
masterfrom
copilot/fix-editor-height-issue
Draft

Make position editor modal height adaptive across displays#620
benckx with Copilot wants to merge 3 commits into
masterfrom
copilot/fix-editor-height-issue

Conversation

Copilot AI commented May 13, 2026

Copy link
Copy Markdown
Contributor

The position editor modal used fixed heights, which could make it render too tall on some display scaling setups. This updates the modal to size from its content and stay constrained to the viewport when space is limited.

  • Modal sizing

    • Replace hard-coded modal heights with content-driven sizing
    • Cap modal height to the viewport to avoid oversized rendering on scaled/high-DPI displays
  • Overflow behavior

    • Add vertical scrolling inside the modal when content exceeds the available viewport height
    • Preserve the existing width and overall layout structure
  • Responsive cleanup

    • Remove the mobile-specific fixed height so small screens follow the same adaptive sizing behavior
#position-editor-modal {
    width: 900px;
    height: auto;
    max-height: calc(100vh - 40px);
    overflow-y: auto;
}

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • accounts.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5278 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.IlynqJ --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10129423026882770650,6001450965452048142,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15710397035038678172,8471158058407603715,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --allow-file-access-from-files --window-size=1600,1400 --screenshot=/tmp/position-editor.png file:///tmp/position-editor-preview.html (dns block)
  • clients2.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5278 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.IlynqJ --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10129423026882770650,6001450965452048142,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15710397035038678172,8471158058407603715,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --allow-file-access-from-files --window-size=1600,1400 --screenshot=/tmp/position-editor.png file:///tmp/position-editor-preview.html (dns block)
  • dl.google.com
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.prefs/java.util.prefs=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED --add-exports=jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED --add-opens=java.base/java.nio.charset=ALL-UNNAMED --add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.base/java.util.concurrent=ALL-UNNAMED --add-opens=java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens=java.xml/javax.xml.namespace=ALL-UNNAMED --add-opens=java.base/java.time=ALL-UNNAMED -XX:MaxMetaspaceSize=384m -XX:+HeapDumpOnOutOfMemoryError -Xms256m -Xmx512m -Dfile.encoding=UTF-8 -Duser.country -Duser.language=en (dns block)
  • redirector.gvt1.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5278 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.IlynqJ --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10129423026882770650,6001450965452048142,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15710397035038678172,8471158058407603715,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --allow-file-access-from-files --window-size=1600,1400 --screenshot=/tmp/position-editor.png file:///tmp/position-editor-preview.html (dns block)
  • www.google.com
    • Triggering command: /proc/self/exe /proc/self/exe --type=utility --utility-sub-type=network.mojom.NetworkService --lang=en-US --service-sandbox-type=network --no-sandbox --use-angle=swiftshader-webgl --crashpad-handler-pid=5278 --enable-crash-reporter=, --noerrdialogs --user-data-dir=/tmp/org.chromium.Chromium.scoped_dir.IlynqJ --change-stack-guard-on-fork=enable --shared-files=network_parent_dirs_pipe:100,v8_context_snapshot_data:101 --field-trial-handle=3,i,10129423026882770650,6001450965452048142,262144 --disable-features=PaintHolding --variations-seed-version --pseudonymization-salt-handle=7,i,15710397035038678172,8471158058407603715,4 --trace-process-track-uuid=3190708989122997041 (dns block)
    • Triggering command: /usr/bin/chromium-browser chromium-browser --headless --disable-gpu --no-sandbox --allow-file-access-from-files --window-size=1600,1400 --screenshot=/tmp/position-editor.png file:///tmp/position-editor-preview.html (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Fix editor height issue on 4K displays Make position editor modal height adaptive across displays May 13, 2026
Copilot AI requested a review from benckx May 13, 2026 12:34
Copilot finished work on behalf of benckx May 13, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

on some display, position editor height is too large

2 participants