Skip to content

Add confirmation before erasing game history on import or position edit #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add confirmation before erasing game history on import or position edit #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bac1147
Initial plan
Copilot May 13, 2026
f3f79de
feat: add confirmation dialog when importing moves or editing positio…
Copilot May 13, 2026
b14c63e
refactor: extract UI.openWithConfirmation helper to remove duplicated…
Copilot May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions webapp/src/main/resources/public/js/analysis-board/analysis-board.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,12 @@ class AnalysisBoardPage extends BasePage {
// init import moves modal
UI.preloadModal(Modals.IMPORT_MOVES);
this.#moveTreeWidget.importMovesCallback = () => {
UI.showModalByName(Modals.IMPORT_MOVES, () => {
new ImportMovesHandler(this.#boardGui, this.#moveTreeWidget);
});
UI.openWithConfirmation(
!this.#moveTreeWidget.isEmpty(),
'Importing moves will erase the current game history. Continue?',
'import',
() => UI.showModalByName(Modals.IMPORT_MOVES, () => new ImportMovesHandler(this.#boardGui, this.#moveTreeWidget))
);
};

// move history drop down menu (to import moves, etc.)
Expand Down
18 changes: 12 additions & 6 deletions webapp/src/main/resources/public/js/analysis-board/move-history-drop-down-menu.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,15 +46,21 @@ class MoveHistoryDropDownMenuWidget extends DropDownMenu {

// callbacks
this.addSimpleItem('Import moves', () => {
UI.showModalByName(Modals.IMPORT_MOVES, () => {
new ImportMovesHandler(boardGui, moveTreeWidget);
});
UI.openWithConfirmation(
!moveTreeWidget.isEmpty(),
'Importing moves will erase the current game history. Continue?',
'import',
() => UI.showModalByName(Modals.IMPORT_MOVES, () => new ImportMovesHandler(boardGui, moveTreeWidget))
);
});

this.addSimpleItem('Edit start position', () => {
UI.showModalByName(Modals.POSITION_EDITOR, () => {
new PositionEditorHandler(getCurrentStartFenCb, selectedFenCb);
});
UI.openWithConfirmation(
!moveTreeWidget.isEmpty(),
'Editing the start position will erase the current game history. Continue?',
'continue',
() => UI.showModalByName(Modals.POSITION_EDITOR, () => new PositionEditorHandler(getCurrentStartFenCb, selectedFenCb))
);
});

// register
Expand Down
17 changes: 17 additions & 0 deletions webapp/src/main/resources/public/js/modules/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,6 +814,23 @@ class UI {
});
}

/**
* Open a modal, showing a confirmation dialog first if shouldConfirm is true.
*
* @param shouldConfirm {boolean}
* @param confirmText {string}
* @param yesButtonText {string}
* @param openFn {function}
*/
static openWithConfirmation(shouldConfirm, confirmText, yesButtonText, openFn) {
if (shouldConfirm) {
const text = buildSimpleSpan(confirmText);
UI.showConfirmationModal(text, openFn, yesButtonText, () => UI.hideModal(null), 'cancel');
} else {
openFn();
}
}

/**
* @param modalName {string}
* @param loadedCallback {function}
Expand Down
7 changes: 7 additions & 0 deletions webapp/src/main/resources/public/js/widgets/move-tree-widget.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1559,6 +1559,13 @@ class MoveTreeWidget {
}
}

/**
* @return {boolean}
*/
isEmpty() {
return this.#moveTree.isEmpty();
}

/**
* Append to the end or branch off (depending on which node is selected)
*
Expand Down
9 changes: 6 additions & 3 deletions webapp/src/main/resources/public/js/widgets/settings-manager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,12 @@ class SettingsGui {
enableEditPositionButton(getCurrentStartFenCb, selectedFenCb) {
this.#editPositionItem.style.display = 'block';
this.#editPositionButton.onclick = () => {
UI.showModalByName(Modals.POSITION_EDITOR, () => {
new PositionEditorHandler(getCurrentStartFenCb, selectedFenCb);
});
UI.openWithConfirmation(
this.#moveTreeWidget != null && !this.#moveTreeWidget.isEmpty(),
'Editing the start position will erase the current game history. Continue?',
'continue',
() => UI.showModalByName(Modals.POSITION_EDITOR, () => new PositionEditorHandler(getCurrentStartFenCb, selectedFenCb))
);
};
addToolTip(this.#editPositionButton, 'Edit start position');

Expand Down