Skip to content

Add id global#21

Merged
benjaminhlina merged 1 commit into
benjaminhlina:mainfrom
DavisVaughan:fix/dplyr
Jan 13, 2026
Merged

Add id global#21
benjaminhlina merged 1 commit into
benjaminhlina:mainfrom
DavisVaughan:fix/dplyr

Conversation

@DavisVaughan

Copy link
Copy Markdown
Contributor

Hi there, we are working on the next version of dplyr and your package was flagged in our reverse dependency checks.

Your package does one of two things:

  • It re-exports dplyr::id(), which has been defunct for many years and has now been removed from dplyr.

  • It references a column named id, likely in a mutate() or summarise(), but does not note this as a global variable with utils::globalVariables("id"). In this case, you got lucky that dplyr exported id(), meaning that you did not need a global variable for "id". Since we have removed dplyr::id(), your package will need this now.

dplyr will be released on January 31, 2026. If you could please send an update of your package to CRAN before then, that would help us out a lot! Thanks!

@benjaminhlina

Copy link
Copy Markdown
Owner

Thank you for the information - I will accept and push the newest version to CRAN.

@codecov

codecov Bot commented Jan 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@59e8c13). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #21   +/-   ##
=======================================
  Coverage        ?   99.57%           
=======================================
  Files           ?       10           
  Lines           ?      703           
  Branches        ?        0           
=======================================
  Hits            ?      700           
  Misses          ?        3           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benjaminhlina benjaminhlina reopened this Jan 13, 2026
@benjaminhlina benjaminhlina merged commit 637c843 into benjaminhlina:main Jan 13, 2026
11 checks passed
@benjaminhlina

Copy link
Copy Markdown
Owner

@DavisVaughan This has been submitted to CRAN will confirm upon acceptance

@benjaminhlina

Copy link
Copy Markdown
Owner

@DavisVaughan it has been accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants