Skip to content

Add support for Office 2007+ documents and for reading date formatted colunmns#4

Closed
brian-pickens wants to merge 6 commits into
bennadel:masterfrom
brian-pickens:master
Closed

Add support for Office 2007+ documents and for reading date formatted colunmns#4
brian-pickens wants to merge 6 commits into
bennadel:masterfrom
brian-pickens:master

Conversation

@brian-pickens
Copy link
Copy Markdown

These changes add in support for reading and writing Office 2007+ documents as well as support for reading in date formatted columns.

@arthurblake
Copy link
Copy Markdown

What's different in your date fix from pull request #3?

@brian-pickens
Copy link
Copy Markdown
Author

My date fix grabs the cells date format string and uses that to format the
java date object. Effectively it gets the date value exactly how it was in
the Excel document.

On Wed, Apr 30, 2014 at 1:34 PM, Arthur Blake notifications@github.comwrote:

What's different in your date fix from pull request #3#3
?


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-41832540
.

@brian-pickens
Copy link
Copy Markdown
Author

Honestly though I'm not trying to compete with your patch, I just happen to
prefer my approach.

On Wed, Apr 30, 2014 at 1:38 PM, brian pickens brian.m.pickens@gmail.comwrote:

My date fix grabs the cells date format string and uses that to format the
java date object. Effectively it gets the date value exactly how it was in
the Excel document.

On Wed, Apr 30, 2014 at 1:34 PM, Arthur Blake notifications@github.comwrote:

What's different in your date fix from pull request #3#3
?


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-41832540
.

@arthurblake
Copy link
Copy Markdown

OK. I just wasn't sure what was different. So are you saying that my patch would break on certain date formats?

@brian-pickens
Copy link
Copy Markdown
Author

I don't think it would. Looking at your patch, it looks like the incoming
date value will always be formatted as M/D/YY no matter what the format is
in the excel document. So that would be the difference. Mine would be
formatted in the same way it is formatted in the excel document whatever
that might be.

On Wed, Apr 30, 2014 at 1:51 PM, Arthur Blake notifications@github.comwrote:

OK. I just wasn't sure what was different. So are you saying that my patch
would break on certain date formats?


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-41834500
.

@arthurblake
Copy link
Copy Markdown

OK. Now if we can only get bennadel to accept these pull requests. Not sure he's paying attention as mine and one other have been sitting out there for months.

@brian-pickens
Copy link
Copy Markdown
Author

Yeah noticed that. No matter. GitHub makes it pretty easy for people to see
our changes and grab our versions if they want.

On Wed, Apr 30, 2014 at 1:58 PM, Arthur Blake notifications@github.comwrote:

OK. Now if we can only get bennadel to accept these pull requests. Not
sure he's paying attention as mine and one other have been sitting out
there for months.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-41835428
.

@apendrag0n3
Copy link
Copy Markdown

Solomon87 - How can I pull your version for testing?

dominic-horbas and others added 2 commits September 24, 2015 14:34
Using the xssf objects instead of the old hssf
Update to create XLSX documents with the custom tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants