feat(ddk-manager): add DDK_ALLOW_UNCONFIRMED_SPLICE env var for 0-conf splice#155
Closed
matthewjablack wants to merge 1 commit into
Closed
feat(ddk-manager): add DDK_ALLOW_UNCONFIRMED_SPLICE env var for 0-conf splice#155matthewjablack wants to merge 1 commit into
matthewjablack wants to merge 1 commit into
Conversation
…f splice Allow signing DLC inputs from Signed (unconfirmed) contracts when DDK_ALLOW_UNCONFIRMED_SPLICE=true is set. This enables 0-conf splice operations on testnets without waiting for on-chain confirmation. By default, the behavior is unchanged - only Confirmed contracts can be used for DLC input signing. The env var opt-in allows testnet deployments to skip the confirmation wait for faster iteration.
Contributor
|
Allowing 0-conf DLC input signing is not a harmless dev convenience, it changes the trust model. A misconfigured production deployment could silently set this. Consider:
|
Owner
|
Closing this. If this feature is wanted, should just set NB_CONFIRMATIONS to 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DDK_ALLOW_UNCONFIRMED_SPLICEenvironment variable to allow signing DLC inputs fromSigned(unconfirmed) contractsConfirmedcontracts allowed without the env varUse Case
On testnets (e.g., testnet4), waiting for confirmations slows down development and testing. This env var allows deployments to opt-in to 0-conf DLC input signing for faster iteration.
Usage
Changes
ddk-manager/src/dlc_input.rs: Addedallow_unconfirmed_splice()helper and updatedget_signature_for_dlc_inputto acceptContract::Signedwhen env var is set