Skip to content

🎨 Palette: [UX improvement] Add fieldset to background removal radio group - #241

Open
benpiper wants to merge 1 commit into
mainfrom
palette-ux-fieldset-radio-3755162760283523161
Open

🎨 Palette: [UX improvement] Add fieldset to background removal radio group#241
benpiper wants to merge 1 commit into
mainfrom
palette-ux-fieldset-radio-3755162760283523161

Conversation

@benpiper

Copy link
Copy Markdown
Owner

What: Replaced the generic

and grouping for the "Background Removal Method" radio buttons with a and in web_app/templates/index.html.
Why: Grouping radio buttons with a generic
and causes screen readers to announce the radio buttons without the overarching group context. Using a provides this semantic context.
Before/After: The visual design remains identical thanks to inline CSS resetting the default borders and margins, but the underlying DOM is structurally sound.
Accessibility: Screen reader users will now correctly hear "Background Removal Method" announced as the group name when navigating to the radio buttons, improving overall form accessibility.


PR created automatically by Jules for task 3755162760283523161 started by @benpiper

…group

**What:** Replaced the generic <div> and <label> grouping for the "Background Removal Method" radio buttons with a <fieldset> and <legend> in web_app/templates/index.html.
**Why:** Grouping radio buttons with a generic <div> and <label> causes screen readers to announce the radio buttons without the overarching group context. Using a <fieldset> provides this semantic context.
**Before/After:** The visual design remains identical thanks to inline CSS resetting the <fieldset> default borders and margins, but the underlying DOM is structurally sound.
**Accessibility:** Screen reader users will now correctly hear "Background Removal Method" announced as the group name when navigating to the radio buttons, improving overall form accessibility.

Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant