Skip to content

🎨 Palette: Add fieldset and legend to radio button group - #246

Open
benpiper wants to merge 1 commit into
mainfrom
palette-fieldset-radio-buttons-1038378757848141575
Open

🎨 Palette: Add fieldset and legend to radio button group#246
benpiper wants to merge 1 commit into
mainfrom
palette-fieldset-radio-buttons-1038378757848141575

Conversation

@benpiper

Copy link
Copy Markdown
Owner

💡 What: Replaced a generic div and label with a semantic <fieldset> and <legend> for the background removal method radio buttons.
🎯 Why: Improves context for screen reader users by properly grouping radio buttons so they know what the options relate to.
📸 Before/After: Visuals remain unchanged due to inline CSS border: none; padding: 0; margin: 0;.
♿ Accessibility: Added structural context for screen readers navigating the radio group.


PR created automatically by Jules for task 1038378757848141575 started by @benpiper

💡 What: Replaced a generic `div` and `label` with a semantic `<fieldset>` and `<legend>` for the background removal method radio buttons.
🎯 Why: Improves context for screen reader users by properly grouping radio buttons so they know what the options relate to.
📸 Before/After: Visuals remain unchanged due to inline CSS `border: none; padding: 0; margin: 0;`.
♿ Accessibility: Added structural context for screen readers navigating the radio group.

Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant