Skip to content

⚡ Bolt: Offload CPU-bound bcrypt operations to threadpool - #101

Open
benpiper wants to merge 1 commit into
mainfrom
bolt-bcrypt-threadpool-7654194860464215965
Open

⚡ Bolt: Offload CPU-bound bcrypt operations to threadpool#101
benpiper wants to merge 1 commit into
mainfrom
bolt-bcrypt-threadpool-7654194860464215965

Conversation

@benpiper

@benpiper benpiper commented Jul 9, 2026

Copy link
Copy Markdown
Owner

💡 What:
Refactored verify_password and get_password_hash in backend/auth.py to be asynchronous, utilizing starlette.concurrency.run_in_threadpool to offload the underlying bcrypt.checkpw and bcrypt.hashpw operations to a separate thread. Updated related usages in backend/main.py.

🎯 Why:
FastAPI operates on an asynchronous event loop. By default, bcrypt performs intensive CPU-bound calculations that block the main event loop if executed directly. This meant that while one user was authenticating (logging in or registering), the entire server would stall, delaying all other concurrent requests.

📊 Impact:
Prevents blocking of the main thread during authentication processes. This significantly improves the application's overall concurrency, throughput, and responsiveness, particularly under load where multiple authentication requests may occur simultaneously.

🔬 Measurement:
The structural change forces bcrypt into a thread pool (verifiable via code inspection). The system will now demonstrably handle higher concurrent request loads without connection timeouts during user login spikes (e.g. load test with multiple simultaneous logins compared to a baseline). Tests (cd backend && uv run pytest tests/) pass smoothly and linting (cd backend && uv run ruff check .) is successful.


PR created automatically by Jules for task 7654194860464215965 started by @benpiper

Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant