⚡ Bolt: Offload CPU-bound bcrypt operations to threadpool - #101
Conversation
Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Refactored
verify_passwordandget_password_hashinbackend/auth.pyto be asynchronous, utilizingstarlette.concurrency.run_in_threadpoolto offload the underlyingbcrypt.checkpwandbcrypt.hashpwoperations to a separate thread. Updated related usages inbackend/main.py.🎯 Why:
FastAPI operates on an asynchronous event loop. By default,
bcryptperforms intensive CPU-bound calculations that block the main event loop if executed directly. This meant that while one user was authenticating (logging in or registering), the entire server would stall, delaying all other concurrent requests.📊 Impact:
Prevents blocking of the main thread during authentication processes. This significantly improves the application's overall concurrency, throughput, and responsiveness, particularly under load where multiple authentication requests may occur simultaneously.
🔬 Measurement:
The structural change forces
bcryptinto a thread pool (verifiable via code inspection). The system will now demonstrably handle higher concurrent request loads without connection timeouts during user login spikes (e.g. load test with multiple simultaneous logins compared to a baseline). Tests (cd backend && uv run pytest tests/) pass smoothly and linting (cd backend && uv run ruff check .) is successful.PR created automatically by Jules for task 7654194860464215965 started by @benpiper