⚡ Bolt: Offload CPU-bound bcrypt operations to thread pool - #103
Conversation
This change refactors `get_password_hash` and `verify_password` in `backend/auth.py` to be `async def` and use `starlette.concurrency.run_in_threadpool`. It also updates the `login`, `register`, and `setup` endpoints in `backend/main.py` to `await` these functions. This prevents `bcrypt` from blocking the async event loop during authentication requests, improving application responsiveness and concurrency. Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What: Offloaded
bcryptoperations (get_password_hash,verify_password) to a thread pool.🎯 Why:
bcryptis a CPU-bound operation that blocks the event loop in async FastAPI routes, causing performance degradation and reduced concurrency during authentication endpoints.📊 Impact: Prevents event loop blocking during password hashing, significantly improving responsiveness under load.
🔬 Measurement: Observe improved throughput and lower latency for concurrent requests to login/register endpoints under load. Verify via load tests or by checking event loop blocking metrics.
PR created automatically by Jules for task 3596773509592585090 started by @benpiper