⚡ Bolt: Offload bcrypt operations to threadpool in async routes - #107
⚡ Bolt: Offload bcrypt operations to threadpool in async routes#107benpiper wants to merge 1 commit into
Conversation
Offloaded CPU-bound `bcrypt` operations in `backend/auth.py` to `starlette.concurrency.run_in_threadpool`. Modified `verify_password` and `get_password_hash` to be async and updated their call sites in `backend/auth.py` and `backend/main.py`. This prevents `bcrypt` from blocking the `asyncio` event loop during login and registration, improving concurrent performance. Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What
Offloaded CPU-bound
bcryptoperations (bcrypt.checkpwandbcrypt.hashpw) to a background thread usingstarlette.concurrency.run_in_threadpool. Convertedverify_passwordandget_password_hashtoasync defand updated all call sites acrossbackend/auth.pyandbackend/main.pytoawaitthem.🎯 Why
bcrypthashing and verification are computationally expensive (by design). When executed directly inside a FastAPIasync defendpoint (like/api/auth/login), these synchronous, CPU-bound operations block the asyncio event loop for the duration of the hashing process. This prevents the server from handling any other concurrent requests, severely degrading throughput and increasing latency during authentication bursts. Offloading them to a threadpool ensures the event loop remains responsive.📊 Impact
Prevents event loop blocking during password verification and hashing. Expected to significantly improve concurrent request throughput (QPS) and reduce latency jitter for all non-authentication endpoints during periods of high login/registration activity.
🔬 Measurement
Run
pytestto ensure authentication logic remains functional. Profile event loop responsiveness (e.g., usingasynciodebug mode or load testing tools likelocust/wrk) while simulating multiple concurrent login requests. You should observe that non-auth requests are no longer queued/delayed behind auth requests.PR created automatically by Jules for task 4530374919660479394 started by @benpiper