Skip to content

⚡ Bolt: Offload bcrypt operations to threadpool in async routes - #107

Open
benpiper wants to merge 1 commit into
mainfrom
bolt-async-bcrypt-4530374919660479394
Open

⚡ Bolt: Offload bcrypt operations to threadpool in async routes#107
benpiper wants to merge 1 commit into
mainfrom
bolt-async-bcrypt-4530374919660479394

Conversation

@benpiper

Copy link
Copy Markdown
Owner

💡 What

Offloaded CPU-bound bcrypt operations (bcrypt.checkpw and bcrypt.hashpw) to a background thread using starlette.concurrency.run_in_threadpool. Converted verify_password and get_password_hash to async def and updated all call sites across backend/auth.py and backend/main.py to await them.

🎯 Why

bcrypt hashing and verification are computationally expensive (by design). When executed directly inside a FastAPI async def endpoint (like /api/auth/login), these synchronous, CPU-bound operations block the asyncio event loop for the duration of the hashing process. This prevents the server from handling any other concurrent requests, severely degrading throughput and increasing latency during authentication bursts. Offloading them to a threadpool ensures the event loop remains responsive.

📊 Impact

Prevents event loop blocking during password verification and hashing. Expected to significantly improve concurrent request throughput (QPS) and reduce latency jitter for all non-authentication endpoints during periods of high login/registration activity.

🔬 Measurement

Run pytest to ensure authentication logic remains functional. Profile event loop responsiveness (e.g., using asyncio debug mode or load testing tools like locust/wrk) while simulating multiple concurrent login requests. You should observe that non-auth requests are no longer queued/delayed behind auth requests.


PR created automatically by Jules for task 4530374919660479394 started by @benpiper

Offloaded CPU-bound `bcrypt` operations in `backend/auth.py` to `starlette.concurrency.run_in_threadpool`. Modified `verify_password` and `get_password_hash` to be async and updated their call sites in `backend/auth.py` and `backend/main.py`. This prevents `bcrypt` from blocking the `asyncio` event loop during login and registration, improving concurrent performance.

Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant