⚡ Bolt: Offload CPU-bound bcrypt operations to threadpool - #108
Conversation
Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Modified
verify_passwordandget_password_hashinbackend/auth.pyto beasyncand offloaded the underlyingbcryptoperations to Starlette's threadpool usingstarlette.concurrency.run_in_threadpool. Updated callers inbackend/main.pyandbackend/auth.pytoawaitthese functions.🎯 Why:
bcrypt.checkpwandbcrypt.hashpware intentionally slow, CPU-bound operations. When executed directly within a FastAPIasync defendpoint (such as/api/auth/login), they block the event loop entirely. This means while one user is logging in, no other async requests (like video processing status checks or media serving) can be handled, causing severe performance degradation under load.📊 Impact: Prevents the FastAPI event loop from stalling during login and registration. This dramatically improves the concurrency and responsiveness of the application under multi-user load, allowing other endpoints to continue serving requests while password hashes are computed on background threads.
🔬 Measurement: Tested using
pytestto ensure authentication logic remains completely functional. Concurrency can be verified by running a load test against/api/auth/loginand simultaneously hitting another fast endpoint like/health—the fast endpoint will no longer stall waiting for the login requests to finish.PR created automatically by Jules for task 14395000185252322556 started by @benpiper