Skip to content

⚡ Bolt: Offload CPU-bound bcrypt operations to threadpool - #108

Open
benpiper wants to merge 1 commit into
mainfrom
bolt/offload-bcrypt-14395000185252322556
Open

⚡ Bolt: Offload CPU-bound bcrypt operations to threadpool#108
benpiper wants to merge 1 commit into
mainfrom
bolt/offload-bcrypt-14395000185252322556

Conversation

@benpiper

Copy link
Copy Markdown
Owner

💡 What: Modified verify_password and get_password_hash in backend/auth.py to be async and offloaded the underlying bcrypt operations to Starlette's threadpool using starlette.concurrency.run_in_threadpool. Updated callers in backend/main.py and backend/auth.py to await these functions.

🎯 Why: bcrypt.checkpw and bcrypt.hashpw are intentionally slow, CPU-bound operations. When executed directly within a FastAPI async def endpoint (such as /api/auth/login), they block the event loop entirely. This means while one user is logging in, no other async requests (like video processing status checks or media serving) can be handled, causing severe performance degradation under load.

📊 Impact: Prevents the FastAPI event loop from stalling during login and registration. This dramatically improves the concurrency and responsiveness of the application under multi-user load, allowing other endpoints to continue serving requests while password hashes are computed on background threads.

🔬 Measurement: Tested using pytest to ensure authentication logic remains completely functional. Concurrency can be verified by running a load test against /api/auth/login and simultaneously hitting another fast endpoint like /health—the fast endpoint will no longer stall waiting for the login requests to finish.


PR created automatically by Jules for task 14395000185252322556 started by @benpiper

Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant