Skip to content

⚡ Bolt: Use binary search in onTimeUpdate for better playback performance - #86

Open
benpiper wants to merge 1 commit into
mainfrom
bolt-binary-search-time-update-15517346830319619168
Open

⚡ Bolt: Use binary search in onTimeUpdate for better playback performance#86
benpiper wants to merge 1 commit into
mainfrom
bolt-binary-search-time-update-15517346830319619168

Conversation

@benpiper

Copy link
Copy Markdown
Owner
  • 💡 What: Replaced the O(N) linear search loop in handleTimeUpdate with an O(log N) binary search algorithm, and added an explanatory comment.
  • 🎯 Why: handleTimeUpdate is triggered very frequently by <video onTimeUpdate>. Iterating sequentially through potentially large arrays of timestamps can block the main thread.
  • 📊 Impact: Lookups scale logarithmically instead of linearly, preventing CPU spikes and jank during playback of long videos.
  • 🔬 Measurement: Observe CPU usage profiling during playback in the browser dev tools, and ensure playback remains smooth. Ensure timeline scrolling still syncs.

PR created automatically by Jules for task 15517346830319619168 started by @benpiper

…ance

Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant