Skip to content

⚡ Bolt: Replace blocking time.sleep with asyncio.sleep in get_frame_image - #91

Open
benpiper wants to merge 1 commit into
mainfrom
bolt/fix-async-sleep-13287616315286611189
Open

⚡ Bolt: Replace blocking time.sleep with asyncio.sleep in get_frame_image#91
benpiper wants to merge 1 commit into
mainfrom
bolt/fix-async-sleep-13287616315286611189

Conversation

@benpiper

Copy link
Copy Markdown
Owner

💡 What: Replaced the synchronous time.sleep(1) call with await asyncio.sleep(1) inside the get_frame_image endpoint in backend/main.py. Added code comments explaining the optimization.

🎯 Why: In a FastAPI application, using a blocking I/O call like time.sleep() inside an async def route handler completely blocks the main asyncio event loop. This prevents the server from processing any other concurrent requests while sleeping (which can be up to 30 seconds for missing frames).

📊 Impact: Resolves a critical concurrency bottleneck. The server can now handle multiple incoming requests smoothly instead of completely freezing while polling for frame creation.

🔬 Measurement: Check server responsiveness when requesting missing frames (e.g. testing concurrent API hits).


PR created automatically by Jules for task 13287616315286611189 started by @benpiper

…mage

Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant