⚡ Bolt: Prevent event loop blocking in async routes - #96
Conversation
Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Wrapped CPU-bound
bcrypthashing/verification functions (get_password_hashandverify_password) inbackend/auth.pywithstarlette.concurrency.run_in_threadpool, making them asynchronous, and updated all callers inbackend/main.pyandbackend/auth.pytoawaitthem. Also replaced a synchronoustime.sleep(1)loop inget_frame_imagewithawait asyncio.sleep(1).🎯 Why: In FastAPI, running CPU-bound operations (like bcrypt) or synchronous blocking calls (
time.sleep) directly insideasync defroutes blocks the entire event loop. This starves the server and prevents it from handling concurrent requests effectively.📊 Impact: Significantly improves server concurrency and responsiveness, eliminating bottlenecks during user authentication and image polling.
🔬 Measurement: Verified functionality by passing all existing backend tests (
pytest tests/). Performance improvements can be measured under load testing by observing the API's concurrent request handling capabilities.PR created automatically by Jules for task 8965965160403963842 started by @benpiper