Skip to content

⚡ Bolt: Offload CPU-bound bcrypt hashing to threadpool - #97

Open
benpiper wants to merge 1 commit into
mainfrom
bolt/optimize-bcrypt-threadpool-6186333561947249382
Open

⚡ Bolt: Offload CPU-bound bcrypt hashing to threadpool#97
benpiper wants to merge 1 commit into
mainfrom
bolt/optimize-bcrypt-threadpool-6186333561947249382

Conversation

@benpiper

@benpiper benpiper commented Jul 6, 2026

Copy link
Copy Markdown
Owner

💡 What: Refactored verify_password and get_password_hash in backend/auth.py to be async functions that offload the CPU-bound operations (bcrypt.checkpw and bcrypt.hashpw) to a threadpool using starlette.concurrency.run_in_threadpool. Updated all callers in backend/auth.py and backend/main.py to await these functions.

🎯 Why: Previously, password hashing and verification ran synchronously on the main thread in FastAPI's event loop. Because bcrypt operations are highly CPU-intensive, they blocked the event loop, severely degrading the application's ability to handle concurrent asynchronous requests (e.g., handling other HTTP routes while a user is logging in). Offloading these to a threadpool frees the event loop, improving overall throughput.

📊 Impact: Prevents event loop starvation during authentication endpoints (like /api/auth/login). Micro-benchmarks confirmed the underlying bcrypt operations take ~340ms per call; moving this off the main thread directly increases the app's concurrent request capacity.

🔬 Measurement:

  1. Verified behavior manually via test scripts.
  2. Ran cd backend && uv run pytest tests/ which completed successfully with all tests passing.
  3. Added a journal entry to .jules/bolt.md documenting this event-loop blocking anti-pattern and solution.

PR created automatically by Jules for task 6186333561947249382 started by @benpiper

Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant