π‘οΈ Sentinel: [HIGH] Add rate limiting to login endpoint - #98
π‘οΈ Sentinel: [HIGH] Add rate limiting to login endpoint#98benpiper wants to merge 1 commit into
Conversation
Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: Brute-force risk on login endpoint due to lack of specific rate-limiting. The global rate limit is too permissive for sensitive auth routes.
π― Impact: Attackers could launch high-volume password guessing attacks against user accounts without being restricted.
π§ Fix: Introduced
_login_rate_limiterinbackend/main.pyusing a separatePerIPRateLimiterconfigured specifically for the login route, defaulting to 5 calls per 300 seconds. Added a check within the/api/auth/loginendpoint that raises a 429 error if the limit is exceeded.β Verification:
backend/main.py.uv run ruff check .), and the backend test suite (uv run pytest tests/)..jules/sentinel.md.PR created automatically by Jules for task 3901587921100545985 started by @benpiper