⚡ Bolt: Offload CPU-bound bcrypt operations to threadpool - #99
Conversation
Synchronous CPU-bound operations like `bcrypt` hashing block the asyncio event loop in FastAPI, causing concurrency degradation under load. Wrapped heavy CPU-bound operations using `starlette.concurrency.run_in_threadpool` and made caller functions `async` to preserve the non-blocking nature of the event loop. Co-authored-by: benpiper <4343814+benpiper@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Refactored
verify_passwordandget_password_hashinbackend/auth.pyto beasyncfunctions that offloadbcrypthashing to a threadpool via Starlette'srun_in_threadpool. Updated callers inbackend/main.py.🎯 Why: Hashing and verifying passwords using
bcrypttakes hundreds of milliseconds and is CPU-bound. In FastAPI, blocking the asyncio event loop with CPU-bound synchronous code halts all other concurrent requests, tanking throughput under load. Offloading these to a threadpool preserves event loop responsiveness.📊 Impact: Significantly improves concurrency and prevents a single login or registration request from blocking the entire server for other users.
🔬 Measurement: Tested via unit tests (
cd backend && uv run pytest tests/) and by ensuring lint passes (cd backend && uv run ruff check .). Concurrency testing would show the API remaining responsive to requests while passwords are being hashed.PR created automatically by Jules for task 13785528567249135508 started by @benpiper