feat: ResponsiveContainer for auto-sizing charts to parent (#120)#130
Merged
Conversation
GoldenChart components require explicit width/height. This wrapper observes its `<div>` with ResizeObserver and hands the measured size to a render-prop child, so charts can fill their parent in flex/grid dashboards. - new src/components/ResponsiveContainer.tsx — ResizeObserver-backed, SSR-safe (renders nothing without a defaultSize until first measure), with aspectRatio derivation, min/max clamps, debounced updates - pure `computeResponsiveSize` helper extracted + unit-tested (project convention: no jsdom — see InteractiveChart.test.ts) - exported from goldenchart and goldenchart/components - README quick-start gains a responsive example Bundle 48 KB gzipped (budget 75 KB).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<ResponsiveContainer>render-prop wrapper usingResizeObserver. SSR-safe (renders nothing without adefaultSizeuntil first measurement), supportsaspectRatio,minWidth,minHeight,maxHeight, debounced updates.computeResponsiveSizehelper extracted so the size-derivation logic is unit-tested (project convention is no-jsdom; seesrc/interactive/InteractiveChart.test.ts).goldenchartandgoldenchart/componentsbarrels.Verification
npm run typecheckcleannpx vitest run src/components/ResponsiveContainer.test.ts— 7 tests passnpm run build && npm run check:bundle— browser entry 48 KB gzipped (budget 75 KB)Test plan
Closes #120.