Skip to content

code-review review-loop crashes with NameError: Path not defined when beliefs file has .py references #13

Description

@benthomasson

Description

When review-loop is called with a --beliefs file that contains .py file references, it crashes at cli.py:1166:

full_ref = Path(repo) / ref_path
NameError: name 'Path' is not defined

Root Cause

pathlib.Path is used in the review_loop command (line 1166) and the review command (lines 1384, 1392, 1397) but was never imported. The fix is to add from pathlib import Path to the module imports.

Fix

Fixed in commit 9f36a3d — added the missing import.

Impact

This caused all --code-review runs within ftl-sdlc-loop to silently fail (exit code 1) when a beliefs file was provided, meaning no review was posted to the PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions