Skip to content

fix(make): make test and test-cfs shell-free for Windows make - #10

Merged
benweru merged 1 commit into
mainfrom
fix/make-test-windows-shell-free
Oct 16, 2026
Merged

benweru merged 1 commit into
mainfrom
fix/make-test-windows-shell-free

Conversation

@benweru

@benweru benweru commented Oct 16, 2026

Copy link
Copy Markdown
Owner

What and why

make test used POSIX [ -x ... ] in its recipe. With plain make on Windows the recipe runs under cmd and fails. This PR moves the interpreter choice into make itself, the way make dataset already does it. RUN_PY is the venv python if it exists, otherwise $(PYTHON), and test, test-cfs and dataset all use it.

How it was verified

Before, on main, Windows 11 with scoop make and no SHELL override:

make : -x was unexpected at this time.
make: *** [Makefile:18: test] Error 255

After, same machine, plain make test:

.venv/Scripts/python -m pytest -q -m "not cfs and not docker and not linux_i2c"
................................s....sss...............................  [100%]
67 passed, 4 skipped, 15 deselected in 5.56s

Fallback when there's no venv (make -n test VENV=nonexistent):

python -m pytest -q -m "not cfs and not docker and not linux_i2c"

Linux CI runs make test. See the check on this PR.

Co-authored-by: Cursor <cursoragent@cursor.com>
@benweru
benweru merged commit a9b93f6 into main Oct 16, 2026
1 check passed
@benweru
benweru deleted the fix/make-test-windows-shell-free branch October 16, 2026 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant