Skip to content

Conversation

@berkus
Copy link
Owner

@berkus berkus commented Sep 26, 2025

Fix reminder actor to properly sleep, see tqwewe/kameo#238 for context.

@berkus berkus requested a review from Copilot September 26, 2025 01:25
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the reminder actor to implement proper sleep functionality for scheduled tasks, addressing a specific issue with the actor's timing mechanism. The changes move from individual message handlers with blocking sleep operations to a centralized scheduling system using a min-heap and the actor's next() method.

Key changes:

  • Replaced individual scheduling message handlers with a unified job queue system using BinaryHeap<ReminderJob>
  • Implemented custom next() method to handle timed operations with tokio::select! for proper async sleep
  • Added a new debug command for testing actor functionality

Reviewed Changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
bot/src/commands/mod.rs Adds module declaration and export for the new debug command
bot/src/commands/debug_command.rs New debug command for testing actor functionality and bot health checks
bot/src/actors/reminder_actor.rs Major refactor implementing job queue scheduling system with proper async sleep handling
bot/src/actors/bot_actor.rs Updates to support the new reminder actor structure and adds debug message handling
bot/Cargo.toml Reorders dependency declarations (cosmetic change)
Justfile Adds default command to list available just commands
Cargo.toml Updates kameo dependency version and reorders workspace configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@berkus berkus merged commit 519bdba into main Sep 26, 2025
1 check passed
@berkus berkus deleted the fix/reminder-actor branch September 26, 2025 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants