Skip to content

Fix path separator assertions in tests for Windows compatibility #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bernardladenthin merged 1 commit into from
Jun 26, 2026
Merged

Fix path separator assertions in tests for Windows compatibility #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/test/java/net/ladenthin/maven/llamacpp/aiindex/prompt/AiPromptSupportTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import static org.hamcrest.MatcherAssert.assertThat;
import static org.junit.jupiter.api.Assertions.assertThrows;

import java.nio.file.Path;
import java.nio.file.Paths;
import java.util.Arrays;
import java.util.Collections;
Expand All @@ -32,7 +33,11 @@ public void buildPromptRendersFileNameAndSource() {
@Test
public void buildPromptUsesFullPathWhenFileNameNull() {
AiPromptSupport support = new AiPromptSupport(Collections.singletonList(def("summary", "[%s] %s")));
assertThat(support.buildPrompt("summary", Paths.get("/"), "x"), is("[/] x"));
// A root path has a null getFileName() on every OS, so buildPrompt falls back to the full
// path string. Derive the expected separator from the same Path so the assertion holds on
// Windows too (the root renders with the platform separator: "/" on POSIX, "\" on Windows).
Path root = Paths.get("/");
assertThat(support.buildPrompt("summary", root, "x"), is("[" + root + "] x"));
}

@Test
Expand Down
10 changes: 7 additions & 3 deletions ...test/java/net/ladenthin/maven/llamacpp/aiindex/provider/MockAiGenerationProviderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import static org.hamcrest.MatcherAssert.assertThat;

import java.io.IOException;
import java.nio.file.Path;
import java.nio.file.Paths;
import net.ladenthin.maven.llamacpp.aiindex.document.AiGenerationRequest;
import net.ladenthin.maven.llamacpp.aiindex.document.AiMdHeader;
Expand All @@ -30,9 +31,12 @@ public void generateUsesFileNameOnly() throws IOException {

@Test
public void generateFallsBackToFullPathWhenFileNameNull() throws IOException {
// A root path has a null getFileName(); the provider must use file.toString().
AiGenerationRequest request = new AiGenerationRequest("summary", Paths.get("/"), "src", HEADER);
assertThat(provider.generate(request), is("Mock summary for /"));
// A root path has a null getFileName(); the provider must use file.toString(). Derive the
// expected separator from the same Path so the assertion holds on Windows too (the root
// renders with the platform separator: "/" on POSIX, "\" on Windows).
Path root = Paths.get("/");
AiGenerationRequest request = new AiGenerationRequest("summary", root, "src", HEADER);
assertThat(provider.generate(request), is("Mock summary for " + root));
}

@Test
Expand Down
Loading