Skip to content

[upstream #16462] 16462: point themeDefinitionSchema doc comment at data-provider theme.ts #182

Description

@berry-13

Follow-up from LibreChat-AI#16462.

The doc comment above themeDefinitionSchema in packages/data-provider/src/config.ts says token names and value ranges are checked by the client registry, "which owns the token list". After LibreChat-AI#16462 the token lists and collectThemeIssues live in packages/data-provider/src/theme.ts and the config loader runs them at load. The comment should point there instead.

It was left out of LibreChat-AI#16462 because four open canary PRs (LibreChat-AI#15911, LibreChat-AI#15684, LibreChat-AI#13811, LibreChat-AI#12273) edit config.ts. Change it once those have landed, or fold it into whichever of them touches that block.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: packagesreviewctl followups statefixedreviewctl followups staterefactorreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions