Skip to content

[upstream #16466] Move saveDrafts, isTemporary and the queue run-end atoms after #15684, #16457, #13811 merge #186

Description

@berry-13

LibreChat-AI#16466 supplies app-global chat preferences through a host ChatSettings context, but only for preferences whose every chat reader can move. Two stay on the Recoil store because files in open PRs also read them:

Once LibreChat-AI#15684, LibreChat-AI#16457 and LibreChat-AI#13811 merge, move each preference with all of its readers in one change, so no reader acts on a different value than the host supplies (Codex findings on LibreChat-AI#16466: r4127216363, r4127216375).

Also deferred from the same inventory: the queue run-end atoms (runEndByIndex, pendingRunEndByConvoId, drainAfterAbortByIndex, settledQueuedTurnReceiptsByConvoId, pendingQueuedTurnEnqueueIdsByConvoId) share Recoil transactions with queuedMessagesByConvoId, whose conversion is blocked by useResumeOnLoad.spec (LibreChat-AI#13811); convert that group together after LibreChat-AI#13811.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: clientreviewctl followups statereadyreviewctl followups staterefactorreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions