You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[upstream #13811] Load Retention Config on the Archive Route Before Saving #190
POST /api/convos/archive (api/server/routes/convos.js) calls saveConvo with interfaceConfig: req?.config?.interfaceConfig, but the route is registered without configMiddleware, so req.config is always undefined there. Every retention decision inside saveConvo therefore sees no retention mode:
under retentionMode: "all" (already on dev and canary), archiving or unarchiving a legacy row does not give it the general-chat deadline the other save paths heal in;
The retention PR's contract treats metadata-only operations (delete, tag rename, project membership, share updates, and archive by the same reasoning) as non-conversion triggers, and the missing middleware predates the PR and affects the all mode too.
What a fix probably looks like
Add configMiddleware to the archive route (as /update already has), or pass the resolved config explicitly, and cover archive and unarchive under all and ephemeral with the real saveConvo. Decide whether archive should be a conversion trigger at all, since the ephemeral contract currently says metadata-only operations are not.
Activity