Skip to content

[upstream #16789] 16789: Disambiguate machines that share a display name in the workspace menu #281

Description

@berry-13

Found while reviewing LibreChat-AI#16789 (local review finding local:a61609d:L-002).

The composer workspace menu titles each machine section with the environment's display name only. When two attached environments share a display name and each holds a workspace with the same name, repository and ref, the two sections and their rows read identically, so a reader cannot tell which machine a pick lands on. The heading ambiguity predates LibreChat-AI#16789 (the base also titled sections by name only); LibreChat-AI#16789 keeps a workspace id visible only when names collide within one machine.

Suggested fix: when environment display names collide in the menu, show the environment id (or another stable disambiguator) beside the heading, and compute workspace name collisions across all rendered sections.

Surface: client/src/components/Chat/Input/CodeWorkspaceMenu.tsx (EnvironmentWorkspaces heading and sharedNames).

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: clientreviewctl followups stateblocked: root openreviewctl followups statebugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions