config: default transient prompts on in lush mode, off in compat modes#363
Merged
Conversation
display.transient_prompt had a default mismatch: the struct default was true (Spec 25) but the CREG schema default was false, and display_sync_to_runtime makes the registry value authoritative -- so fresh installs got transient prompts OFF regardless of the struct intent. Resolve it through the per-mode-default mechanism the other curated lush features use. Lush mode defaults transient prompts on: after a command runs its prompt collapses to a compact form, so the active prompt stands out and elaborate prompts do not accumulate in scrollback. posix, bash, and zsh inherit off, mirroring those shells -- bash has no transient prompt and a vanilla zsh requires a plugin such as powerlevel10k. Verified across all four modes: lush resolves true, posix/bash/zsh resolve false, and a lush -> bash -> lush round-trip restores true.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
display.transient_prompthad a default mismatch: the struct default wastrue(Spec 25) but the CREG schema default wasfalse, anddisplay_sync_to_runtimemakes the registry value authoritative — so freshinstalls got transient prompts OFF regardless of the struct intent.
This resolves it through the per-mode-default mechanism the other curated
lush features (
completion.chain_directories,completion.match_mode, thehistory finder, autosuggestion ranking) already use:
collapses to a compact form, so the active prompt stands out and elaborate
prompts do not accumulate in scrollback
transient prompt; a vanilla zsh requires a plugin such as powerlevel10k)
Verified across all four modes: lush resolves
true, posix/bash/zsh resolvefalse, and a lush → bash → lush round-trip restorestrue. Clean under-Werror; 156/156 tests.
Note:
config seton a display key is still re-seeded by a mode switchbecause the display section is not yet routed through the registry SESSION
layer (config set writes the struct directly). This is pre-existing and
section-wide (e.g.
display.theme_hot_reloadbehaves the same) and isresolved by the separate display→CREG migration; the common case (set
within a mode, no switch) works.