feat: add candidate-ID alignment filtering for query generation#107
Merged
feat: add candidate-ID alignment filtering for query generation#107
Conversation
998f585 to
535f120
Compare
lramir14
approved these changes
Apr 10, 2026
Collaborator
lramir14
left a comment
There was a problem hiding this comment.
Looks good to me. The helper is simple, deterministic, and the tests cover the intended positional alignment behavior well. Only a minor non-blocking docstring nit from my side.
535f120 to
da73553
Compare
da73553 to
f6027d1
Compare
Collaborator
|
Re-reviewed after the latest commit. The docstring concern is addressed, and the implementation matches the intended deterministic positional filtering behavior described in the issue. Approving, and will proceed with the merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a deterministic filtering step for candidate-ID alignment in the synthetic query generation workflow. This enforces positional agreement between expected candidate IDs and LLM outputs.
Key changes
core/querygen/filtering.py:filter_aligned_candidate_ids()for positional candidate-ID reconciliationcandidate_idmatches the expected ID at the same positionQueryBlueprint) and realization (RealizedQuery) outputs via a sharedcandidate_idfieldDesign notes
Alignment is treated as a hard positional contract:
This helper operates as a deterministic aggregate step:
Orchestration note
The intended call pattern in
api/querygen.pyis:Status
Ready for review.