Make 404 Not Found reporting more consistent - #148
Open
wandernauta wants to merge 1 commit into
Open
Conversation
This changes the following: - Some paths had not-found handling that would not set the response status, just a human-readable message or empty string; make this consistent with the other paths (see berthubert#143). - Some paths had 404 response bodies, but these were actually ignored in favor of the response body generated by the error handler. These are now removed. - The original error page would describe 404 errors as a malfunction ('Storing'). That wording is now slightly changed in specifically the 404 case. The other suggestions to users are unchanged. - The original error page would fail to load correctly for some paths. An error page for /foo/bar/baz would look for /foo/bar/pico.min.css, which would fail, and then the font and links on the page would be broken. This sets a sensible base URL with the HTML base element. Where paths had specific logging for the not-found case, this is kept.
Contributor
Author
|
Build failure seems unrelated, see #149. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the following:
Before:
After:
Where paths had specific logging for the not-found case, this is kept.