Indicate search result itemlimit truncation in UI - #151
Open
wandernauta wants to merge 2 commits into
Open
Conversation
This is based on berthubert#140, but with a slight twist; the item limit is still not documented because I imagine it is not guaranteed and may change in future, but the response does now indicate whether truncation has happened. This is also exposed to the user interface, which recommends asking a more specific query. The total number of matches is not computed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #140, but with a slight twist; the item limit is still not documented because I imagine it is not guaranteed and may change in future, but the response does now indicate whether truncation has happened. This is also exposed to the user interface, which recommends asking a more specific query.
Normal case, fewer than 280 results:
Truncated case, 280 results (but there could be more):
The total number of potential matches is not returned.
This PR also contains the changes from #149.
This is technically independent of the changes in #150 but it would probably be least confusing to merge that first.