Add Paper Figure Studio and OpticalSetup bridge ports - #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the greenfield PicSetup successor under
app/while leaving the immutableprototype/production snapshot unchanged.optical,electrical,rf,control, andannotationconnections while admitting only optical links to the coherent scattering solve;setup-port/1OpticalSetup sender, bridge manifest export, and a framework-neutral receiver adapter;app/instead of the preserved prototype snapshot.Model and integration boundary
PicSetup owns the scalar guided-mode network. OpticalSetup continues to own free-space geometry, beam waist, numerical aperture, wavefront, laboratory coordinates, and receiver-side scene creation.
The bridge is a deterministic, inspectable document handoff. It is not live synchronization or a distributed multi-physics solve. The included receiver adapter is a focused integration proposal; it has not been deployed to
LucaGenchi/optics-sketch.Semantic JSON preserves the complete hybrid figure graph. SAX and gdsfactory scaffolds deliberately contain only physical optical topology.
Validation
npm run app:check— passednpm run app:test— 19 passed, 0 failednpm run app:build— passed; generated output remains ignorednpm run prototype:test— 14 passed, 0 failednpm run prototype:check— passedgit diff --check— passedprototype/tree — preservedDeployment authorization
On 2026-07-28, the repository owner explicitly authorized merging this PR and replacing the GitHub Pages publication artifact with the greenfield PicSetup app under
app/. The source snapshot underprototype/remains preserved in the repository for provenance and rollback.Reviewer focus
setup-port/1expose the correct power references, units, omissions, and ownership boundary?