fix: treat all failed lyrics search responses as no results

[boidushya]

Overview

A search where the only provider to respond errored (Portato hitting a QQ 429/503, say) used to blow up the whole panel with a red "Better Lyrics Portato: ... rate limit reached ・ Try adjusting your search" screen, even though the real answer was just "no lyrics for this track". Confusing, especially when the query was fine and the backend was the problem.

Now every provider treats any failed fetch as an empty result. All 4xx and all 5xx (no more special-casing 429 or throwing on 5xx), plus network and parse failures, resolve to no results and log a single line to the console instead of throwing. A plain 404 miss stays silent since that is the ordinary empty case.

With providers no longer throwing, the search UI is purely results-driven: show results if any, otherwise the existing "No matches" screen. Dropped the now-dead error screen, the "Search failed" status, and the isClientError helper the old subset approach needed.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	composer	00dd240	Commit Preview URL Branch Preview URL	Aug 30 2026, 06:39 PM

[github-actions]

React Doctor found no new issues. 🎉

_{Reviewed by React Doctor for commit 00dd240.}