fix(deploy): require three consecutive ready responses before the smoke test - #65
Merged
Conversation
…ke test The readiness fix closed one race and revealed a second. webapps-deploy returns while the old process is still serving, so a single /ready 200 can come from the outgoing instance seconds before App Service restarts it. The wait passed on that stale answer and the smoke test landed mid-restart — the same 500-on-every- endpoint signature, on a build that served 200 everywhere once it settled. One ready answer proves the old instance was alive. Three in a row spanning twenty seconds cannot all be the doomed instance. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readiness fix (#61) closed one race and revealed a second, one layer down.
The refactor merge deploy failed at the smoke test with the familiar 500-on-every-endpoint signature — on a build that serves 200 everywhere now. The deploy step itself succeeded; the gate measured at the wrong moment again, but for a new reason:
webapps-deployreturns while the old process is still serving. A single/api/health/ready200 can come from the outgoing instance seconds before App Service restarts it. The wait accepted that stale answer, the restart began, and the smoke test landed mid-restart.One ready answer proves the old instance was alive. Three in a row spanning twenty seconds cannot all be the doomed instance. Streak resets on any non-200, retry budget unchanged.
actionlintclean; the repository's own workflow rules pass.