fix(tests): resolve the five CodeQL findings the coverage push introduced - #69
Merged
Conversation
…uced The zero-open-alerts state is an invariant now, so the new test code holds to the same bar as the product code. MemoryCache is IDisposable and was constructed per scanner without disposal; the test class now owns one per instance and disposes it. The fake handler built responses inside Task.FromResult, where the analyzer loses the ownership transfer — they are built in methods that return them directly, with the transfer documented. The key-directory cleanup swallowed every exception; only the two a filesystem delete can produce are caught now. 147 tests pass. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+154
to
+156
| catch (IOException) | ||
| { | ||
| } |
Comment on lines
+157
to
+159
| catch (UnauthorizedAccessException) | ||
| { | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The coverage push brought the repository to 292 tests — and five new CodeQL findings in the new test code. Zero open alerts is an invariant now, so test code holds the same bar as product code.
MemoryCache(IDisposable) built per scanner, never disposedTask.FromResult, where the analyzer loses the ownership transferusings the listing;GetStringAsyncdisposes internally) documentedcatch { }in test cleanupIOException/UnauthorizedAccessException— the two a filesystem delete can produce147 Infrastructure tests pass; no product code touched.