Bring the frontend branch's NuGet packages in line with main - #128
Merged
Conversation
…main This branch carries src/Lottery.Api and its CI builds and tests it, but until the dependabot.yml entry added in #117 it was never scanned - so its packages drifted behind main's: dbup-sqlserver 6.0.16 -> 7.2.0 Microsoft.NET.Test.Sdk 17.14.1 -> 18.9.0 xunit.runner.visualstudio 3.1.5 -> 4.0.0 Dependabot opened #122, #123 and #124 for these and all three failed the same way: each package is CentralTransitive, so it updated Directory.Packages.props without regenerating packages.lock.json, and CI restores with --locked-mode, which fails NU1004. It then closed them itself as 'no longer updatable'. Doing them together with the lock files regenerated (--force-evaluate) is what main needed in #85 for the same dbup-sqlserver bump. Microsoft.Data.SqlClient is deliberately left at 6.1.6: #123 proposed 7.0.2, a major, and main is still on 6.1.6 - matching main is the target here, not getting ahead of it. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AWkVh7cyAz1gWapBH1CY8n
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #122, #123 and #124, which Dependabot opened and then closed itself.
This branch carries
src/Lottery.Apiand its CI builds and tests it, but until thedependabot.ymlentry added in #117 it was never scanned — so its packages drifted behindmain's:dbup-sqlserverMicrosoft.NET.Test.Sdkxunit.runner.visualstudioWhy the Dependabot PRs couldn't work
All three are CentralTransitive dependencies. Dependabot updates
Directory.Packages.propsbut cannot regeneratepackages.lock.json, and CI restores with--locked-mode:This is the same problem
mainhit — #85 is titled "Bump dbup-sqlserver 6.0.16 → 7.2.0 (with all lock files synced)" for exactly this reason. Doing all three together withdotnet restore --force-evaluateis the fix.Dependabot subsequently closed #122/#123/#124 on its own with "no longer updatable", which is a misread — they were still behind. It will re-propose them on its next weekly run and hit the same NU1004 unless the versions land first, which is what this PR does.
Deliberately not included
Microsoft.Data.SqlClientstays at 6.1.6. #123 proposed 7.0.2, a major, andmainis still on 6.1.6 — matching main is the goal here, not getting ahead of it. Worth doing on both branches together, separately.Verification
dotnet restore --locked-modeclean,dotnet build -warnaserrorwith zero warnings, and all 68 backend tests on this branch pass (Domain 24, Application 19, Infrastructure 25).🤖 Generated with Claude Code